From 8a374df80191e9830f11d5d5db7b13e21da86dbe Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Fri, 5 May 2023 17:02:50 +0100 Subject: [PATCH] BlockTranslator: remove useless call to generateDataFromStateId() BlockStateDictionary doesn't retain BlockStateData anymore, so this optimisation is just wasting CPU cycles. --- src/network/mcpe/convert/BlockTranslator.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/network/mcpe/convert/BlockTranslator.php b/src/network/mcpe/convert/BlockTranslator.php index a14c89d13..4113f86ce 100644 --- a/src/network/mcpe/convert/BlockTranslator.php +++ b/src/network/mcpe/convert/BlockTranslator.php @@ -47,11 +47,9 @@ final class BlockTranslator{ private BlockStateDictionary $blockStateDictionary, private BlockStateSerializer $blockStateSerializer ){ - $this->fallbackStateId = $this->blockStateDictionary->lookupStateIdFromData( - BlockStateData::current(BlockTypeNames::INFO_UPDATE, []) - ) ?? throw new AssumptionFailedError(BlockTypeNames::INFO_UPDATE . " should always exist"); - //lookup the state data from the dictionary to avoid keeping two copies of the same data around - $this->fallbackStateData = $this->blockStateDictionary->generateDataFromStateId($this->fallbackStateId) ?? throw new AssumptionFailedError("We just looked up this state data, so it must exist"); + $this->fallbackStateData = BlockStateData::current(BlockTypeNames::INFO_UPDATE, []); + $this->fallbackStateId = $this->blockStateDictionary->lookupStateIdFromData($this->fallbackStateData) ?? + throw new AssumptionFailedError(BlockTypeNames::INFO_UPDATE . " should always exist"); } public function internalIdToNetworkId(int $internalStateId) : int{