mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 18:32:55 +00:00
Code Issues Projects Releases Wiki Activity

Block: Clean up internal constructor inconsistencies

Browse Source 
I don't dare look how big this commit is or how many bugs it introduced...
This commit is contained in:
Dylan K. Taylor
2019-02-20 19:21:51 +00:00
parent e93464f318
commit 89fce7712a
141 changed files with 427 additions and 1609 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/pocketmine/block/Skull.php
View File

@ -35,8 +35,6 @@ use function floor;
class Skull extends Flowable{
protected $id = self::SKULL_BLOCK;
/** @var int */
protected $facing = Facing::NORTH;
@ -44,10 +42,6 @@ class Skull extends Flowable{
/** @var int */
protected $rotation = 0; //TODO: split this into floor skull and wall skull handling
public function __construct(){
}
protected function writeStateToMeta() : int{
return $this->facing;
}
@ -69,10 +63,6 @@ class Skull extends Flowable{
}
}
protected function getTileClass() : ?string{
return TileSkull::class;
}
public function writeStateToWorld() : void{
parent::writeStateToWorld();
//extra block properties storage hack
@ -87,10 +77,6 @@ class Skull extends Flowable{
return 1;
}
public function getName() : string{
return "Mob Head";
}
protected function recalculateBoundingBox() : ?AxisAlignedBB{
//TODO: different bounds depending on attached face
return AxisAlignedBB::one()->contract(0.25, 0, 0.25)->trim(Facing::UP, 0.5);