mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

BlockFactory::get() second parameter is now mandatory

Browse Source
This commit is contained in:
Dylan K. Taylor
2020-11-18 00:50:01 +00:00
parent 28335e3c45
commit 870d237260
4 changed files with 363 additions and 363 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/phpunit/block/BlockTest.php
View File

@ -51,7 +51,7 @@ class BlockTest extends TestCase{
public function testDeliberateOverrideBlock() : void{
$block = new MyCustomBlock(new BlockIdentifier(BlockLegacyIds::COBBLESTONE), "Cobblestone", BlockBreakInfo::instant());
$this->blockFactory->register($block, true);
self::assertInstanceOf(MyCustomBlock::class, $this->blockFactory->get($block->getId()));
self::assertInstanceOf(MyCustomBlock::class, $this->blockFactory->get($block->getId(), 0));
}
/**
@ -62,7 +62,7 @@ class BlockTest extends TestCase{
if(!$this->blockFactory->isRegistered($i)){
$b = new StrangeNewBlock(new BlockIdentifier($i), "Strange New Block", BlockBreakInfo::instant());
$this->blockFactory->register($b);
self::assertInstanceOf(StrangeNewBlock::class, $this->blockFactory->get($b->getId()));
self::assertInstanceOf(StrangeNewBlock::class, $this->blockFactory->get($b->getId(), 0));
return;
}
}
@ -93,8 +93,8 @@ class BlockTest extends TestCase{
*/
public function testBlockFactoryClone() : void{
for($i = 0; $i < 256; ++$i){
$b1 = $this->blockFactory->get($i);
$b2 = $this->blockFactory->get($i);
$b1 = $this->blockFactory->get($i, 0);
$b2 = $this->blockFactory->get($i, 0);
self::assertNotSame($b1, $b2);
}
}
@ -126,7 +126,7 @@ class BlockTest extends TestCase{
public function testBlockIds() : void{
for($i = 0; $i < 256; ++$i){
$b = $this->blockFactory->get($i);
$b = $this->blockFactory->get($i, 0);
self::assertContains($i, $b->getIdInfo()->getAllBlockIds());
}
}