mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-25 21:04:06 +00:00
Code Issues Projects Releases Wiki Activity

LevelManager::generateLevel(): avoid multiple return points

Browse Source 
this could cause unexpected results if additional code is added after background generation in the future.
This commit is contained in:
Dylan K. Taylor 2019-04-26 18:05:34 +01:00
parent 7c7f42eba6
commit 854c3a816c
1 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/level/LevelManager.php
View File

@ -292,10 +292,7 @@ class LevelManager{
(new LevelLoadEvent($level))->call(); (new LevelLoadEvent($level))->call();
if(!$backgroundGeneration){ if($backgroundGeneration){
return true;
}
$this->server->getLogger()->notice($this->server->getLanguage()->translateString("pocketmine.level.backgroundGeneration", [$name])); $this->server->getLogger()->notice($this->server->getLanguage()->translateString("pocketmine.level.backgroundGeneration", [$name]));
$spawnLocation = $level->getSpawnLocation(); $spawnLocation = $level->getSpawnLocation();
@ -320,6 +317,7 @@ class LevelManager{
Level::getXZ($index, $chunkX, $chunkZ); Level::getXZ($index, $chunkX, $chunkZ);
$level->populateChunk($chunkX, $chunkZ, true); $level->populateChunk($chunkX, $chunkZ, true);
} }
}
return true; return true;
} }