mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 04:17:07 +00:00
Code Issues Projects Releases Wiki Activity

PHPStan: don't remember possibly-impure function return values

Browse Source 
I don't think we get much benefit from this, and the assumption that functions with a return value are pure is sketchy.
In any case, it's better to avoid these repeated calls anyway.
This commit is contained in:
Dylan K. Taylor 2025-01-08 02:04:06 +00:00
parent d42ec06647
commit 847ae26cad
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
phpstan.neon.dist
View File

@ -19,6 +19,7 @@ rules:
parameters: parameters:
level: 9 level: 9
checkMissingCallableSignature: true checkMissingCallableSignature: true
rememberPossiblyImpureFunctionValues: false #risky to remember these, better for performance to avoid repeated calls anyway
treatPhpDocTypesAsCertain: false treatPhpDocTypesAsCertain: false
bootstrapFiles: bootstrapFiles:
- tests/phpstan/bootstrap.php - tests/phpstan/bootstrap.php

5
src/entity/projectile/Projectile.php
View File

@ -290,10 +290,11 @@ abstract class Projectile extends Entity{
$damage = $this->getResultDamage(); $damage = $this->getResultDamage();
if($damage >= 0){ if($damage >= 0){
if($this->getOwningEntity() === null){ $owner = $this->getOwningEntity();
if($owner === null){
$ev = new EntityDamageByEntityEvent($this, $entityHit, EntityDamageEvent::CAUSE_PROJECTILE, $damage); $ev = new EntityDamageByEntityEvent($this, $entityHit, EntityDamageEvent::CAUSE_PROJECTILE, $damage);
}else{ }else{
$ev = new EntityDamageByChildEntityEvent($this->getOwningEntity(), $this, $entityHit, EntityDamageEvent::CAUSE_PROJECTILE, $damage); $ev = new EntityDamageByChildEntityEvent($owner, $this, $entityHit, EntityDamageEvent::CAUSE_PROJECTILE, $damage);
} }
$entityHit->attack($ev); $entityHit->attack($ev);

3
src/permission/BanEntry.php
View File

@ -101,11 +101,12 @@ class BanEntry{
} }
public function getString() : string{ public function getString() : string{
$expires = $this->getExpires();
return implode("|", [ return implode("|", [
$this->getName(), $this->getName(),
$this->getCreated()->format(self::$format), $this->getCreated()->format(self::$format),
$this->getSource(), $this->getSource(),
$this->getExpires() === null ? "Forever" : $this->getExpires()->format(self::$format), $expires === null ? "Forever" : $expires->format(self::$format),
$this->getReason() $this->getReason()
]); ]);
} }