mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-16 19:59:11 +00:00
Code Issues Projects Releases Wiki Activity

Update comment about suffixed parameters

Browse Source
This commit is contained in:
Dylan K. Taylor
2025-10-13 20:02:42 +01:00
parent 371b991692
commit 835faa4925
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/mcpe/NetworkSession.php
View File

@@ -1151,9 +1151,11 @@ class NetworkSession{
$translated = $name instanceof Translatable ? $language->translate($name) : $name;
if($suffix !== ""){
//umm... client only allows suffixes on integer params???
//TODO: as of 1.21.111, the client crashes if we try to provide actual suffixes for /xp and
//I can't be bothered to debug it. Fill this with string for now.
//$parameters[] = CommandParameter::postfixed($translated, strtolower($suffix), flags: 0, optional: $k >= $required);
//TODO: as of 1.21.111, the client crashes if we try to provide actual suffixes for /xp.
//The cause for this seems to be undefined behaviour on the client linked to the order and
//number of certain hardcoded enums like GameMode, IntParam etc which we don't provided. I
//wasn't able to make a reliable workaround, so this gets disabled for now. SAD!
//$parameters[] = CommandParameter::postfixed($translated, strtolower($suffix), optional: $k >= $required);
$parameters[] = CommandParameter::standard($translated, CommandParameterTypes::ID, optional: $k >= $required);
}else{
$parameters[] = CommandParameter::standard($translated, $simpleArgType, optional: $k >= $required);