mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 02:08:21 +00:00
Code Issues Projects Releases Wiki Activity

RakLib: split PthreadsChannelWriter into two implementations

Browse Source 
this gains a very small performance improvement by avoiding unnecessary !== null checks on every packet written in either direction. It's insignificant for sure, but I just found this code in an old stash, so what the heck.
This commit is contained in:
Dylan K. Taylor
2021-07-22 18:52:58 +01:00
parent 5c609cc1c1
commit 832a156fc7
3 changed files with 44 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/mcpe/raklib/PthreadsChannelWriter.php
View File

@ -23,18 +23,12 @@ use raklib\server\ipc\InterThreadChannelWriter;
final class PthreadsChannelWriter implements InterThreadChannelWriter{
/** @var \Threaded */
private $buffer;
/** @var SleeperNotifier|null */
private $notifier;
public function __construct(\Threaded $buffer, ?SleeperNotifier $notifier = null){
public function __construct(\Threaded $buffer){
$this->buffer = $buffer;
$this->notifier = $notifier;
}
public function write(string $str) : void{
$this->buffer[] = $str;
if($this->notifier !== null){
$this->notifier->wakeupSleeper();
}
}
}