mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-08 04:38:35 +00:00
Code Issues Projects Releases Wiki Activity

Added some dumb limits

Browse Source
This commit is contained in:
Dylan K. Taylor 2023-03-20 00:54:33 +00:00
parent d57aca1367
commit 804feedb67
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/mcpe/handler/InGamePacketHandler.php
View File

@ -532,6 +532,10 @@ class InGamePacketHandler extends PacketHandler{
} }
private function handleSingleItemStackRequest(ItemStackRequest $request) : ItemStackResponse{ private function handleSingleItemStackRequest(ItemStackRequest $request) : ItemStackResponse{
if(count($request->getActions()) > 20){
//TODO: we can probably lower this limit, but this will do for now
throw new PacketHandlingException("Too many actions in ItemStackRequest");
}
$executor = new ItemStackRequestExecutor($this->player, $this->inventoryManager, $request); $executor = new ItemStackRequestExecutor($this->player, $this->inventoryManager, $request);
try{ try{
$transaction = $executor->generateInventoryTransaction(); $transaction = $executor->generateInventoryTransaction();
@ -547,6 +551,10 @@ class InGamePacketHandler extends PacketHandler{
public function handleItemStackRequest(ItemStackRequestPacket $packet) : bool{ public function handleItemStackRequest(ItemStackRequestPacket $packet) : bool{
$responses = []; $responses = [];
if(count($packet->getRequests()) > 80){
//TODO: we can probably lower this limit, but this will do for now
throw new PacketHandlingException("Too many requests in ItemStackRequestPacket");
}
foreach($packet->getRequests() as $request){ foreach($packet->getRequests() as $request){
$responses[] = $this->handleSingleItemStackRequest($request); $responses[] = $this->handleSingleItemStackRequest($request);
} }