mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-12 08:49:42 +00:00
Code Issues Projects Releases Wiki Activity

inventory: fix some transactions being rejected for no good reason

Browse Source 
since 1.13, transactions such as interacting with creative inventory cause a spoof windowID 124 slot 50 action to appear which changes air -> air. This currently gets rejected because only cursor is mapped to ID 124, and it only has a single slot.

It is not clear what the purpose of 124:50 is, but this fix filters out any actions which do not change anything, since they won't affect transaction balance anyway.
This commit is contained in:
Dylan K. Taylor 2019-12-02 20:15:22 +00:00
parent b7c4379700
commit 7fdfe947b0
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/network/mcpe/protocol/types/NetworkInventoryAction.php
View File

@ -167,6 +167,10 @@ class NetworkInventoryAction{
* @throws \UnexpectedValueException * @throws \UnexpectedValueException
*/ */
public function createInventoryAction(Player $player){ public function createInventoryAction(Player $player){
if($this->oldItem->equalsExact($this->newItem)){
//filter out useless noise in 1.13
return null;
}
switch($this->sourceType){ switch($this->sourceType){
case self::SOURCE_CONTAINER: case self::SOURCE_CONTAINER:
$window = $player->getWindow($this->windowId); $window = $player->getWindow($this->windowId);