mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 01:46:04 +00:00
Code Issues Projects Releases Wiki Activity

Permission & interface optimization

Browse Source
This commit is contained in:
Shoghi Cervantes
2014-09-11 16:43:11 +02:00
parent 78b4223795
commit 7ef2708fca
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/pocketmine/permission/PermissionAttachment.php
View File

@ -122,7 +122,12 @@ class PermissionAttachment{
*/
public function setPermission($name, $value){
$name = $name instanceof Permission ? $name->getName() : $name;
unset($this->permissions[$name]); //Fixes children getting overwritten
if(isset($this->permissions[$name])){
if($this->permissions[$name] === $value){
return;
}
unset($this->permissions[$name]); //Fixes children getting overwritten
}
$this->permissions[$name] = $value;
$this->permissible->recalculatePermissions();
}
@ -131,8 +136,11 @@ class PermissionAttachment{
* @param string|Permission $name
*/
public function unsetPermission($name){
unset($this->permissions[$name instanceof Permission ? $name->getName() : $name]);
$this->permissible->recalculatePermissions();
$name = $name instanceof Permission ? $name->getName() : $name;
if(isset($this->permissions[$name])){
unset($this->permissions[$name]);
$this->permissible->recalculatePermissions();
}
}
/**