mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Do not persist SimpleChunkManager between async tasks

Browse Source 
this is just asking for memory leaks.
This commit is contained in:
Dylan K. Taylor
2020-12-03 19:46:23 +00:00
parent dde2e7e66f
commit 7edfa3713b
3 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/world/generator/PopulationTask.php
View File

@ -78,7 +78,7 @@ class PopulationTask extends AsyncTask{
return;
}
$generator = $context->getGenerator();
$manager = $context->getChunkManager();
$manager = new SimpleChunkManager($context->getWorldHeight());
/** @var Chunk[] $chunks */
$chunks = [];
@ -124,8 +124,6 @@ class PopulationTask extends AsyncTask{
foreach($chunks as $i => $c){
$this->{"chunk$i"} = $c->isDirty() ? FastChunkSerializer::serializeWithoutLight($c) : null;
}
$manager->cleanChunks();
}
public function onCompletion() : void{