mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-08-31 23:33:06 +00:00
Code Issues Projects Releases Wiki Activity

BaseInventory: improved performance of getContents()

Browse Source 
this old code is extremely inefficient. This showed up distinctly in my crafting bruteforce benchmarks, where I discovered that getContents() accounted for the vast majority of the time taken to match shaped recipes.
This commit is contained in:
Dylan K. Taylor 2018-03-27 10:13:28 +01:00
parent c7e803372c
commit 7e20385bdb
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/pocketmine/inventory/BaseInventory.php
View File

@ -99,10 +99,13 @@ abstract class BaseInventory implements Inventory{
*/ */
public function getContents(bool $includeEmpty = false) : array{ public function getContents(bool $includeEmpty = false) : array{
$contents = []; $contents = [];
for($i = 0, $size = $this->getSize(); $i < $size; ++$i){ $air = null;
$item = $this->getItem($i);
if($includeEmpty or !$item->isNull()){ foreach($this->slots as $i => $slot){
$contents[$i] = $item; if($slot !== null){
$contents[$i] = clone $slot;
}elseif($includeEmpty){
$contents[$i] = $air ?? ($air = ItemFactory::get(Item::AIR, 0, 0));
} }
} }