mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

Revert "Item: restrict bounds of count to 0-255"

Browse Source 
This reverts commit 10317527e4.

this breaks user code which exceeds stack limits in legitimate
circumstances. For example, it should be OK to add 6000x diamond to a
player's inventory without being forced to manually split the count up
for addItem().
This commit is contained in:
Dylan K. Taylor
2020-02-25 20:42:03 +00:00
parent 53067c26d7
commit 7aa8bd18d3
2 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/phpunit/item/ItemTest.php
View File

@ -89,18 +89,4 @@ class ItemTest extends TestCase{
self::assertEquals($id, $item->getId());
self::assertEquals($meta, $item->getDamage());
}
public function testSetCountTooBig() : void{
$this->expectException(\InvalidArgumentException::class);
$item = ItemFactory::get(ItemIds::STONE);
$item->setCount(256);
}
public function testSetCountTooSmall() : void{
$this->expectException(\InvalidArgumentException::class);
$item = ItemFactory::get(ItemIds::STONE);
$item->setCount(-1);
}
}