From 75a2d796715d0d2830b7f3f1d2645b7cecad4bcf Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 24 Aug 2019 15:39:23 +0100 Subject: [PATCH] convert more constant interfaces to final classes, close #2885 --- src/block/BlockLegacyIds.php | 6 +++++- src/block/BlockLegacyMetadata.php | 6 +++++- src/block/BlockToolType.php | 6 +++++- src/item/ItemIds.php | 6 +++++- src/network/mcpe/protocol/ProtocolInfo.php | 6 +++++- src/network/mcpe/protocol/types/DimensionIds.php | 6 +++++- src/network/mcpe/protocol/types/PlayerPermissions.php | 6 +++++- src/network/mcpe/protocol/types/inventory/ContainerIds.php | 6 +++++- src/network/mcpe/protocol/types/inventory/WindowTypes.php | 6 +++++- 9 files changed, 45 insertions(+), 9 deletions(-) diff --git a/src/block/BlockLegacyIds.php b/src/block/BlockLegacyIds.php index 4a1d521c0..c846c74fc 100644 --- a/src/block/BlockLegacyIds.php +++ b/src/block/BlockLegacyIds.php @@ -23,7 +23,11 @@ declare(strict_types=1); namespace pocketmine\block; -interface BlockLegacyIds{ +final class BlockLegacyIds{ + + private function __construct(){ + //NOOP + } public const AIR = 0; public const STONE = 1; diff --git a/src/block/BlockLegacyMetadata.php b/src/block/BlockLegacyMetadata.php index 904f4efc0..016057c4e 100644 --- a/src/block/BlockLegacyMetadata.php +++ b/src/block/BlockLegacyMetadata.php @@ -26,7 +26,11 @@ namespace pocketmine\block; /** * Constants for legacy metadata for various blocks. */ -interface BlockLegacyMetadata{ +final class BlockLegacyMetadata{ + + private function __construct(){ + //NOOP + } public const ANVIL_NORMAL = 0; public const ANVIL_SLIGHTLY_DAMAGED = 4; diff --git a/src/block/BlockToolType.php b/src/block/BlockToolType.php index ca5876359..e7046bd87 100644 --- a/src/block/BlockToolType.php +++ b/src/block/BlockToolType.php @@ -27,7 +27,11 @@ namespace pocketmine\block; * Types of tools that can be used to break blocks * Blocks may allow multiple tool types by combining these bitflags */ -interface BlockToolType{ +final class BlockToolType{ + + private function __construct(){ + //NOOP + } public const NONE = 0; public const SWORD = 1 << 0; diff --git a/src/item/ItemIds.php b/src/item/ItemIds.php index 0aadcf4e0..a38e53171 100644 --- a/src/item/ItemIds.php +++ b/src/item/ItemIds.php @@ -23,7 +23,11 @@ declare(strict_types=1); namespace pocketmine\item; -interface ItemIds{ +final class ItemIds{ + + private function __construct(){ + //NOOP + } public const LIT_BLAST_FURNACE = -214; public const COMPOSTER = -213; diff --git a/src/network/mcpe/protocol/ProtocolInfo.php b/src/network/mcpe/protocol/ProtocolInfo.php index 152dd4463..c6fd51164 100644 --- a/src/network/mcpe/protocol/ProtocolInfo.php +++ b/src/network/mcpe/protocol/ProtocolInfo.php @@ -26,7 +26,11 @@ namespace pocketmine\network\mcpe\protocol; /** * Version numbers and packet IDs for the current Minecraft PE protocol */ -interface ProtocolInfo{ +final class ProtocolInfo{ + + private function __construct(){ + //NOOP + } /** * NOTE TO DEVELOPERS diff --git a/src/network/mcpe/protocol/types/DimensionIds.php b/src/network/mcpe/protocol/types/DimensionIds.php index 2777a0328..855bc94be 100644 --- a/src/network/mcpe/protocol/types/DimensionIds.php +++ b/src/network/mcpe/protocol/types/DimensionIds.php @@ -23,7 +23,11 @@ declare(strict_types=1); namespace pocketmine\network\mcpe\protocol\types; -interface DimensionIds{ +final class DimensionIds{ + + private function __construct(){ + //NOOP + } public const OVERWORLD = 0; public const NETHER = 1; diff --git a/src/network/mcpe/protocol/types/PlayerPermissions.php b/src/network/mcpe/protocol/types/PlayerPermissions.php index 6c9cd376d..04668e4fe 100644 --- a/src/network/mcpe/protocol/types/PlayerPermissions.php +++ b/src/network/mcpe/protocol/types/PlayerPermissions.php @@ -23,7 +23,11 @@ declare(strict_types=1); namespace pocketmine\network\mcpe\protocol\types; -interface PlayerPermissions{ +final class PlayerPermissions{ + + private function __construct(){ + //NOOP + } public const CUSTOM = 3; public const OPERATOR = 2; diff --git a/src/network/mcpe/protocol/types/inventory/ContainerIds.php b/src/network/mcpe/protocol/types/inventory/ContainerIds.php index 6a9e70ba3..2a60e6b29 100644 --- a/src/network/mcpe/protocol/types/inventory/ContainerIds.php +++ b/src/network/mcpe/protocol/types/inventory/ContainerIds.php @@ -23,7 +23,11 @@ declare(strict_types=1); namespace pocketmine\network\mcpe\protocol\types\inventory; -interface ContainerIds{ +final class ContainerIds{ + + private function __construct(){ + //NOOP + } public const NONE = -1; public const INVENTORY = 0; diff --git a/src/network/mcpe/protocol/types/inventory/WindowTypes.php b/src/network/mcpe/protocol/types/inventory/WindowTypes.php index 1f1edbdf7..6ee75daa1 100644 --- a/src/network/mcpe/protocol/types/inventory/WindowTypes.php +++ b/src/network/mcpe/protocol/types/inventory/WindowTypes.php @@ -25,7 +25,11 @@ declare(strict_types=1); namespace pocketmine\network\mcpe\protocol\types\inventory; -interface WindowTypes{ +final class WindowTypes{ + + private function __construct(){ + //NOOP + } public const NONE = -9;