mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 12:18:46 +00:00
Code Issues Projects Releases Wiki Activity

Fixed matchItems corrupting CraftingTransaction internal state on repeated validation

Browse Source 
This bug became apparent while developing a more robust fix for 1.16 crafting.
This commit is contained in:
Dylan K. Taylor 2020-08-02 23:07:47 +01:00
parent df2c3136c9
commit 756840f11d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pocketmine/inventory/transaction/InventoryTransaction.php
View File

@ -136,6 +136,8 @@ class InventoryTransaction{
* @throws TransactionValidationException * @throws TransactionValidationException
*/ */
protected function matchItems(array &$needItems, array &$haveItems) : void{ protected function matchItems(array &$needItems, array &$haveItems) : void{
$needItems = [];
$haveItems = [];
foreach($this->actions as $key => $action){ foreach($this->actions as $key => $action){
if(!$action->getTargetItem()->isNull()){ if(!$action->getTargetItem()->isNull()){
$needItems[] = $action->getTargetItem(); $needItems[] = $action->getTargetItem();