mirror of
https://github.com/pmmp/PocketMine-MP.git
synced 2025-10-19 23:37:45 +00:00
Sound::encode() position is no longer nullable
making this nullable was based on the invalid assumption that global sounds have no position, but it turns out they _do_ still use the position to make the sound come from the correct direction.
This commit is contained in:
@@ -39,7 +39,7 @@ class EntityShortFallSound implements Sound{
|
||||
$this->entity = $entity;
|
||||
}
|
||||
|
||||
public function encode(?Vector3 $pos) : array{
|
||||
public function encode(Vector3 $pos) : array{
|
||||
return [LevelSoundEventPacket::create(
|
||||
LevelSoundEventPacket::SOUND_FALL_SMALL,
|
||||
$pos,
|
||||
|
Reference in New Issue
Block a user