A giant hack to cut down code needed for runtime block serialization by 50%

this also avoids repeated information and inconsistencies.
This commit is contained in:
Dylan K. Taylor
2022-07-18 18:25:41 +01:00
parent cf34f88a67
commit 6d4279671e
90 changed files with 380 additions and 717 deletions

View File

@@ -64,7 +64,7 @@ class Banner extends ItemBlockWallOrFloor{
}
protected function encodeType(RuntimeDataWriter $w) : void{
$w->writeDyeColor($this->color);
$w->dyeColor($this->color);
}
/**

View File

@@ -33,7 +33,7 @@ use pocketmine\math\Facing;
final class CoralFan extends Item{
use CoralTypeTrait {
encodeType as encodeCoralType;
describeType as encodeCoralType;
}
public function __construct(ItemIdentifier $identifier){

View File

@@ -35,7 +35,7 @@ class Dye extends Item{
}
protected function encodeType(RuntimeDataWriter $w) : void{
$w->writeDyeColor($this->color);
$w->dyeColor($this->color);
}
public function getColor() : DyeColor{

View File

@@ -45,7 +45,7 @@ final class ItemBlock extends Item{
}
protected function encodeType(RuntimeDataWriter $w) : void{
$w->writeInt(Block::INTERNAL_STATE_DATA_BITS, $this->blockTypeData);
$w->int(Block::INTERNAL_STATE_DATA_BITS, $this->blockTypeData);
}
public function getBlock(?int $clickedFace = null) : Block{

View File

@@ -37,7 +37,7 @@ class Potion extends Item implements ConsumableItem{
}
protected function encodeType(RuntimeDataWriter $w) : void{
$w->writePotionType($this->potionType);
$w->potionType($this->potionType);
}
public function getType() : PotionType{ return $this->potionType; }

View File

@@ -39,7 +39,7 @@ class SplashPotion extends ProjectileItem{
}
protected function encodeType(RuntimeDataWriter $w) : void{
$w->writePotionType($this->potionType);
$w->potionType($this->potionType);
}
public function getType() : PotionType{ return $this->potionType; }