mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 01:46:04 +00:00
Code Issues Projects Releases Wiki Activity

Fixed usages of BlockDataUpgrader which weren't accounting for thrown exceptions

Browse Source
This commit is contained in:
Dylan K. Taylor
2023-05-02 17:13:31 +01:00
parent 4d0cecbac2
commit 6beb80b8fe
5 changed files with 39 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/world/format/io/BaseWorldProvider.php
View File

@ -67,9 +67,10 @@ abstract class BaseWorldProvider implements WorldProvider{
$newPalette = [];
foreach($palette as $k => $legacyIdMeta){
$newStateData = $this->blockDataUpgrader->upgradeIntIdMeta($legacyIdMeta >> 4, $legacyIdMeta & 0xf);
if($newStateData === null){
//TODO: remember data for unknown states so we can implement them later
//TODO: remember data for unknown states so we can implement them later
try{
$newStateData = $this->blockDataUpgrader->upgradeIntIdMeta($legacyIdMeta >> 4, $legacyIdMeta & 0xf);
}catch(BlockStateDeserializeException $e){
$newStateData = GlobalBlockStateHandlers::getUnknownBlockStateData();
}