mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-01 23:59:53 +00:00
Code Issues Projects Releases Wiki Activity

Fixed unit tests

Browse Source
This commit is contained in:
Dylan K. Taylor 2019-02-21 10:41:06 +00:00
parent 635fb5dde4
commit 6ab171d629
3 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/phpunit/block/BlockTest.php
View File

@ -35,7 +35,7 @@ class BlockTest extends TestCase{
* Test registering a block which would overwrite another block, without forcing it * Test registering a block which would overwrite another block, without forcing it
*/ */
public function testAccidentalOverrideBlock() : void{ public function testAccidentalOverrideBlock() : void{
$block = new MyCustomBlock(); $block = new MyCustomBlock(new BlockIdentifier(Block::COBBLESTONE), "Cobblestone");
$this->expectException(\InvalidArgumentException::class); $this->expectException(\InvalidArgumentException::class);
BlockFactory::register($block); BlockFactory::register($block);
} }
@ -44,7 +44,7 @@ class BlockTest extends TestCase{
* Test registering a block deliberately overwriting another block works as expected * Test registering a block deliberately overwriting another block works as expected
*/ */
public function testDeliberateOverrideBlock() : void{ public function testDeliberateOverrideBlock() : void{
$block = new MyCustomBlock(); $block = new MyCustomBlock(new BlockIdentifier(Block::COBBLESTONE), "Cobblestone");
BlockFactory::register($block, true); BlockFactory::register($block, true);
self::assertInstanceOf(MyCustomBlock::class, BlockFactory::get($block->getId())); self::assertInstanceOf(MyCustomBlock::class, BlockFactory::get($block->getId()));
} }
@ -55,7 +55,7 @@ class BlockTest extends TestCase{
public function testRegisterNewBlock() : void{ public function testRegisterNewBlock() : void{
for($i = 0; $i < 256; ++$i){ for($i = 0; $i < 256; ++$i){
if(!BlockFactory::isRegistered($i)){ if(!BlockFactory::isRegistered($i)){
$b = new StrangeNewBlock($i); $b = new StrangeNewBlock(new BlockIdentifier($i), "Strange New Block");
BlockFactory::register($b); BlockFactory::register($b);
self::assertInstanceOf(StrangeNewBlock::class, BlockFactory::get($b->getId())); self::assertInstanceOf(StrangeNewBlock::class, BlockFactory::get($b->getId()));
return; return;
@ -70,7 +70,7 @@ class BlockTest extends TestCase{
*/ */
public function testRegisterIdTooLarge() : void{ public function testRegisterIdTooLarge() : void{
self::expectException(\RuntimeException::class); self::expectException(\RuntimeException::class);
BlockFactory::register(new OutOfBoundsBlock(25555)); BlockFactory::register(new OutOfBoundsBlock(new BlockIdentifier(25555), "Out Of Bounds Block"));
} }
/** /**
@ -78,7 +78,7 @@ class BlockTest extends TestCase{
*/ */
public function testRegisterIdTooSmall() : void{ public function testRegisterIdTooSmall() : void{
self::expectException(\RuntimeException::class); self::expectException(\RuntimeException::class);
BlockFactory::register(new OutOfBoundsBlock(-1)); BlockFactory::register(new OutOfBoundsBlock(new BlockIdentifier(-1), "Out Of Bounds Block"));
} }
/** /**

3
tests/phpunit/block/MyCustomBlock.php
View File

@ -25,7 +25,4 @@ namespace pocketmine\block;
class MyCustomBlock extends Cobblestone{ class MyCustomBlock extends Cobblestone{
public function getName() : string{
return "MyCobblestone";
}
} }

4
tests/phpunit/block/StrangeNewBlock.php
View File

@ -24,7 +24,5 @@ declare(strict_types=1);
namespace pocketmine\block; namespace pocketmine\block;
class StrangeNewBlock extends Solid{ class StrangeNewBlock extends Solid{
public function getName() : string{
return "Strange New Block";
}
} }