mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-22 11:24:02 +00:00
Code Issues Projects Releases Wiki Activity

ÂBlock: use Facing::OFFSET in getSide()

Browse Source 
instead of the comically inefficient getBlock() + throwaway Position->getSide()
This improved the function's performance by 2.3x.
This commit is contained in:
Dylan K. Taylor 2023-10-19 13:25:32 +01:00
parent ccd2cdd324
commit 6a3ec70c72
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/block/Block.php
View File

@ -747,8 +747,14 @@ class Block{
* @return Block * @return Block
*/ */
public function getSide(int $side, int $step = 1){ public function getSide(int $side, int $step = 1){
if($this->position->isValid()){ $position = $this->position;
return $this->position->getWorld()->getBlock($this->position->getSide($side, $step)); if($position->isValid()){
[$dx, $dy, $dz] = Facing::OFFSET[$side] ?? throw new \InvalidArgumentException("Unknown side $side");
return $position->getWorld()->getBlockAt(
$position->x + ($dx * $step),
$position->y + ($dy * $step),
$position->z + ($dz * $step)
);
} }
throw new \LogicException("Block does not have a valid world"); throw new \LogicException("Block does not have a valid world");