Fixed invalid metadata and updated weak references on PluginManager

This commit is contained in:
Shoghi Cervantes
2014-05-23 22:30:37 +02:00
parent 53749483c3
commit 683ab8d2cd
6 changed files with 61 additions and 26 deletions

View File

@ -45,7 +45,7 @@ abstract class MetadataStore{
return;
}
$key = $this->disambiguate($subject, $newMetadataValue);
$key = $this->disambiguate($subject, $metadataKey);
if(!isset($this->metadataMap[$key])){
$entry = new \WeakMap();
$this->metadataMap[$key] = $entry;
@ -122,10 +122,12 @@ abstract class MetadataStore{
* Creates a unique name for the object receiving metadata by combining
* unique data from the subject with a metadataKey.
*
* @param mixed $subject
* @param string $metadataKey
* @param Metadatable $subject
* @param string $metadataKey
*
* @return string
*
* @throws \InvalidArgumentException
*/
public abstract function disambiguate($subject, $metadataKey);
public abstract function disambiguate(Metadatable $subject, $metadataKey);
}