mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

Task: Remove currentTick parameter (#3498)

Browse Source 
This parameter is not used for the vast majority of task use cases and just serves as extra useless boilerplate code, especially for closure-based tasks.
This use case can be replaced using Server->getTick() in the cases where it matters.
This commit is contained in:
Dylan T
2020-05-16 15:28:45 +01:00
committed by GitHub
parent 38e28f91e8
commit 67666db827
6 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/plugins/TesterPlugin/src/pmmp/TesterPlugin/CheckTestCompletionTask.php
View File

@ -34,7 +34,7 @@ class CheckTestCompletionTask extends Task{
$this->plugin = $plugin;
}
public function onRun(int $currentTick){
public function onRun(){
$test = $this->plugin->getCurrentTest();
if($test === null){
if(!$this->plugin->startNextTest()){