mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-20 07:39:42 +00:00
Code Issues Projects Releases Wiki Activity

Task: Remove currentTick parameter (#3498)

Browse Source 
This parameter is not used for the vast majority of task use cases and just serves as extra useless boilerplate code, especially for closure-based tasks.
This use case can be replaced using Server->getTick() in the cases where it matters.
This commit is contained in:
Dylan T
2020-05-16 15:28:45 +01:00
committed by GitHub
parent 38e28f91e8
commit 67666db827
6 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/scheduler/ClosureTask.php
View File

@@ -31,8 +31,8 @@ use pocketmine\utils\Utils;
* Example usage:
*
* ```
* TaskScheduler->scheduleTask(new ClosureTask(function(int $currentTick) : void{
* echo "HI on $currentTick\n";
* TaskScheduler->scheduleTask(new ClosureTask(function() : void{
* echo "HI\n";
* });
* ```
*/
@@ -40,16 +40,16 @@ class ClosureTask extends Task{
/**
* @var \Closure
* @phpstan-var \Closure(int) : void
* @phpstan-var \Closure() : void
*/
private $closure;
/**
* @param \Closure $closure Must accept only ONE parameter, $currentTick
* @phpstan-param \Closure(int) : void $closure
* @param \Closure $closure Must accept zero parameters
* @phpstan-param \Closure() : void $closure
*/
public function __construct(\Closure $closure){
Utils::validateCallableSignature(function(int $currentTick) : void{}, $closure);
Utils::validateCallableSignature(function() : void{}, $closure);
$this->closure = $closure;
}
@@ -57,7 +57,7 @@ class ClosureTask extends Task{
return Utils::getNiceClosureName($this->closure);
}
public function onRun(int $currentTick) : void{
($this->closure)($currentTick);
public function onRun() : void{
($this->closure)();
}
}