mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 17:59:48 +00:00
Code Issues Projects Releases Wiki Activity

Effect: stop using hardcoded translation keys for names

Browse Source
This commit is contained in:
Dylan K. Taylor
2021-09-03 20:39:02 +01:00
parent 8e58beef7f
commit 665f2473e1
3 changed files with 37 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/entity/effect/Effect.php
View File

@ -26,19 +26,20 @@ namespace pocketmine\entity\effect;
use pocketmine\color\Color;
use pocketmine\entity\Entity;
use pocketmine\entity\Living;
use pocketmine\lang\Translatable;
class Effect{
/**
* @param int $internalRuntimeId Internal runtime ID, unique to this effect type. Used for comparisons.
* @param string $name Translation key used for effect name
* @param Color $color Color of bubbles given by this effect
* @param bool $bad Whether the effect is harmful
* @param bool $hasBubbles Whether the effect has potion bubbles. Some do not (e.g. Instant Damage has its own particles instead of bubbles)
* @param int $internalRuntimeId Internal runtime ID, unique to this effect type. Used for comparisons.
* @param Translatable|string $name Translation key used for effect name
* @param Color $color Color of bubbles given by this effect
* @param bool $bad Whether the effect is harmful
* @param bool $hasBubbles Whether the effect has potion bubbles. Some do not (e.g. Instant Damage has its own particles instead of bubbles)
*/
public function __construct(
protected int $internalRuntimeId,
protected string $name,
protected Translatable|string $name,
protected Color $color,
protected bool $bad = false,
protected bool $hasBubbles = true
@ -55,7 +56,7 @@ class Effect{
/**
* Returns the translation key used to translate this effect's name.
*/
public function getName() : string{
public function getName() : Translatable|string{
return $this->name;
}