mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-06 11:57:10 +00:00
Code Issues Projects Releases Wiki Activity

Task::onRun() and Task::onCancel() now require :void return typehints

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-05-17 13:58:01 +01:00
parent b3454b3488
commit 65f82f5cdf
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/scheduler/Task.php
View File

@ -57,17 +57,13 @@ abstract class Task{
/**
* Actions to execute when run
*
* @return void
*/
abstract public function onRun();
abstract public function onRun() : void;
/**
* Actions to execute if the Task is cancelled
*
* @return void
*/
public function onCancel(){
public function onCancel() : void{
}
}

2
tests/plugins/TesterPlugin/src/pmmp/TesterPlugin/CheckTestCompletionTask.php
View File

@ -34,7 +34,7 @@ class CheckTestCompletionTask extends Task{
$this->plugin = $plugin;
}
public function onRun(){
public function onRun() : void{
$test = $this->plugin->getCurrentTest();
if($test === null){
if(!$this->plugin->startNextTest()){