mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-30 23:29:54 +00:00
Code Issues Projects Releases Wiki Activity

World: Require all adjacent chunks to a ticking chunk candidate to be unlocked, generated, loaded and light-populated

Browse Source 
this should address the remaining problems with grass spread/death.
This commit is contained in:
Dylan K. Taylor 2021-05-17 20:59:40 +01:00
parent 7abf50f503
commit 643c3ed14e
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/world/World.php
View File

@ -1007,23 +1007,18 @@ class World implements ChunkManager{
} }
private function isChunkTickable(int $chunkX, int $chunkZ) : bool{ private function isChunkTickable(int $chunkX, int $chunkZ) : bool{
$chunkHash = World::chunkHash($chunkX, $chunkZ);
if(
!$this->chunks[$chunkHash]->isPopulated() ||
$this->isChunkLocked($chunkX, $chunkZ)
){
return false;
}
//TODO: this might need to be checked after adjacent chunks are loaded in future
$lightPopulatedState = $this->chunks[$chunkHash]->isLightPopulated();
if($lightPopulatedState !== true){
$this->orderLightPopulation($chunkX, $chunkZ);
return false;
}
//check adjacent chunks are loaded
for($cx = -1; $cx <= 1; ++$cx){ for($cx = -1; $cx <= 1; ++$cx){
for($cz = -1; $cz <= 1; ++$cz){ for($cz = -1; $cz <= 1; ++$cz){
if(!isset($this->chunks[World::chunkHash($chunkX + $cx, $chunkZ + $cz)])){ if($this->isChunkLocked($chunkX + $cx, $chunkZ + $cz)){
return false;
}
$adjacentChunk = $this->getChunk($chunkX + $cx, $chunkZ + $cz);
if($adjacentChunk === null || !$adjacentChunk->isPopulated()){
return false;
}
$lightPopulatedState = $adjacentChunk->isLightPopulated();
if($lightPopulatedState !== true){
$this->orderLightPopulation($chunkX + $cx, $chunkZ + $cz);
return false; return false;
} }
} }