Merge branch 'stable'

.github/workflows/draft-release.yml

@@ -68,7 +68,7 @@ jobs:
           done
 
       - name: Build PocketMine-MP.phar
-        run: composer make-server
+        run: php -dphar.readonly=0 build/server-phar.php --git ${{ github.sha }}
 
       - name: Get PocketMine-MP release version
         id: get-pm-version

build/make-release.php

@@ -85,6 +85,7 @@ function main(array $argv) : void{
 		));
 	}
 
+	echo "About to tag version $currentVer. Next version will be $nextVer.\n";
 	echo "please add appropriate notes to the changelog and press enter...";
 	fgets(STDIN);
 	system('git add "' . dirname(__DIR__) . '/changelogs"');

changelogs/3.22.md

@@ -24,3 +24,10 @@ Plugin developers should **only** update their required API to this version if y
 - Fixed items in the crafting grid getting deleted on server-side disconnect or session timeout.
 - A warning is now logged on startup if a debug build of PHP is used to run the server (because it has a significant performance impact).
 - GitHub Actions is now used to build new releases, instead of Jenkins. You can see build logs [here](https://github.com/pmmp/PocketMine-MP/actions/workflows/draft-release.yml).
+
+# 3.22.3
+- Fixed a bug in the release build of 3.22.2 which caused the crash archive to reject all crashdumps.
+- Fixed possible server crash during player spawning.
+
+# 3.22.4
+- Fixed a bug which broke the build of 3.22.3.

phpstan.neon.dist

@@ -26,30 +26,30 @@ parameters:
 	bootstrapFiles:
 		- tests/phpstan/bootstrap.php
 	scanDirectories:
+		- build
 		- tests/plugins/TesterPlugin
 		- tools
 	scanFiles:
 		- src/PocketMine.php
-		- build/make-release.php
-		- build/server-phar.php
-		- build/generate-known-translation-apis.php
 	paths:
+		- build
 		- src
 		- tests/phpstan/rules
-		- build/generate-known-translation-apis.php
-		- build/make-release.php
-		- build/server-phar.php
 		- tests/phpunit
 		- tests/plugins/TesterPlugin
 		- tools
+	excludePaths:
+		analyseAndScan:
+			- build/preprocessor
 	dynamicConstantNames:
 		- pocketmine\VersionInfo::IS_DEVELOPMENT_BUILD
 		- pocketmine\DEBUG
+		- pocketmine\IS_DEVELOPMENT_BUILD
 	stubFiles:
 		- tests/phpstan/stubs/JsonMapper.stub
-		- tests/phpstan/stubs/pthreads.stub
 		- tests/phpstan/stubs/leveldb.stub
 		- tests/phpstan/stubs/phpasn1.stub
+		- tests/phpstan/stubs/pthreads.stub
 	reportUnmatchedIgnoredErrors: false #no other way to silence platform-specific non-warnings
 	staticReflectionClassNamePatterns:
 		- "#^COM$#"