From 62185d476bc2463be6de20604cd4ef83733dcce2 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 14 Mar 2019 15:22:44 +0000 Subject: [PATCH] RegionLoader: Fixed performance issue converting huge worlds I was big nub when i wrote this code. --- src/pocketmine/level/format/io/region/RegionLoader.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/level/format/io/region/RegionLoader.php b/src/pocketmine/level/format/io/region/RegionLoader.php index 3deb687bb..9d0aac0ff 100644 --- a/src/pocketmine/level/format/io/region/RegionLoader.php +++ b/src/pocketmine/level/format/io/region/RegionLoader.php @@ -29,7 +29,7 @@ use pocketmine\utils\Binary; use function ceil; use function chr; use function fclose; -use function fgetc; +use function feof; use function file_exists; use function filesize; use function fopen; @@ -301,7 +301,7 @@ class RegionLoader{ //TODO: more validity checks fseek($this->filePointer, $fileOffset); - if(fgetc($this->filePointer) === false){ //Try and read from the location + if(feof($this->filePointer)){ throw new CorruptedRegionException("Region file location offset x=$x,z=$z points to invalid file location $fileOffset"); } if(isset($usedOffsets[$offset])){