mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-12 14:35:35 +00:00
Code Issues Projects Releases Wiki Activity

CraftingManager: micro optimization: reuse closure for item deserialize & reduce indirection

Browse Source
This commit is contained in:
Dylan K. Taylor 2019-06-16 14:05:37 +01:00
parent 2a5561fcd1
commit 6161155660
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pocketmine/inventory/CraftingManager.php
View File

@ -53,6 +53,7 @@ class CraftingManager{
public function init() : void{ public function init() : void{
$recipes = json_decode(file_get_contents(\pocketmine\RESOURCE_PATH . "vanilla" . DIRECTORY_SEPARATOR . "recipes.json"), true); $recipes = json_decode(file_get_contents(\pocketmine\RESOURCE_PATH . "vanilla" . DIRECTORY_SEPARATOR . "recipes.json"), true);
$itemDeserializerFunc = \Closure::fromCallable([Item::class, 'jsonDeserialize']);
foreach($recipes as $recipe){ foreach($recipes as $recipe){
switch($recipe["type"]){ switch($recipe["type"]){
case "shapeless": case "shapeless":
@ -60,8 +61,8 @@ class CraftingManager{
break; break;
} }
$this->registerRecipe(new ShapelessRecipe( $this->registerRecipe(new ShapelessRecipe(
array_map(function(array $data) : Item{ return Item::jsonDeserialize($data); }, $recipe["input"]), array_map($itemDeserializerFunc, $recipe["input"]),
array_map(function(array $data) : Item{ return Item::jsonDeserialize($data); }, $recipe["output"]) array_map($itemDeserializerFunc, $recipe["output"])
)); ));
break; break;
case "shaped": case "shaped":
@ -70,8 +71,8 @@ class CraftingManager{
} }
$this->registerRecipe(new ShapedRecipe( $this->registerRecipe(new ShapedRecipe(
$recipe["shape"], $recipe["shape"],
array_map(function(array $data) : Item{ return Item::jsonDeserialize($data); }, $recipe["input"]), array_map($itemDeserializerFunc, $recipe["input"]),
array_map(function(array $data) : Item{ return Item::jsonDeserialize($data); }, $recipe["output"]) array_map($itemDeserializerFunc, $recipe["output"])
)); ));
break; break;
case "smelting": case "smelting":