Async chunk compression and serialization is now non-optional

This commit is contained in:
Dylan K. Taylor
2017-05-18 12:19:27 +01:00
parent 85c1535c75
commit 60f5c7ccef
6 changed files with 25 additions and 52 deletions

View File

@ -33,6 +33,7 @@ use pocketmine\nbt\tag\CompoundTag;
use pocketmine\nbt\tag\IntTag;
use pocketmine\nbt\tag\LongTag;
use pocketmine\nbt\tag\StringTag;
use pocketmine\scheduler\AsyncTask;
abstract class BaseLevelProvider implements LevelProvider{
/** @var Level */
@ -41,8 +42,6 @@ abstract class BaseLevelProvider implements LevelProvider{
protected $path;
/** @var CompoundTag */
protected $levelData;
/** @var bool */
protected $asyncChunkRequest = false;
public function __construct(Level $level, string $path){
$this->level = $level;
@ -66,7 +65,6 @@ abstract class BaseLevelProvider implements LevelProvider{
if(!isset($this->levelData->generatorOptions)){
$this->levelData->generatorOptions = new StringTag("generatorOptions", "");
}
$this->asyncChunkRequest = (bool) $this->level->getServer()->getProperty("chunk-sending.async-chunk-request", false);
}
public function getPath() : string{
@ -131,19 +129,12 @@ abstract class BaseLevelProvider implements LevelProvider{
file_put_contents($this->getPath() . "level.dat", $buffer);
}
public function requestChunkTask(int $x, int $z){
public function requestChunkTask(int $x, int $z) : AsyncTask{
$chunk = $this->getChunk($x, $z, false);
if(!($chunk instanceof Chunk)){
throw new ChunkException("Invalid Chunk sent");
}
if($this->asyncChunkRequest){
return new ChunkRequestTask($this->level, $chunk);
}
//non-async, call the callback directly with serialized data
$this->getLevel()->chunkRequestCallback($x, $z, $chunk->networkSerialize());
return null;
return new ChunkRequestTask($this->level, $chunk);
}
}