mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-16 11:58:00 +00:00
Code Issues Projects Releases Wiki Activity

Random: fixed nextSignedInt() not actually returning signed ints

Browse Source 
closes #4646
closes #4645

Impact assessment by core usage search and poggit suggests that the impact of this change will be close to zero.
However, since it changes behaviour which plugins might be unknowingly relying on, it's going into 4.1 rather than a patch release.
This commit is contained in:
Dylan K. Taylor
2021-12-15 00:59:10 +00:00
parent 49a8afd126
commit 60938c8c9d
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/utils/Random.php
View File

@@ -94,7 +94,7 @@ class Random{
$this->z = $this->w;
$this->w = ($this->w ^ (($this->w >> 19) & 0x7fffffff) ^ ($t ^ (($t >> 8) & 0x7fffffff))) & 0xffffffff;
return $this->w;
return Binary::signInt($this->w);
}
/**