mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-05 01:16:15 +00:00
Code Issues Projects Releases Wiki Activity

Fixed a whole bunch of issues with legacy transactions

Browse Source
This commit is contained in:
Dylan K. Taylor
2023-01-04 00:13:51 +00:00
parent 6b2156151f
commit 5fdbb19852
3 changed files with 75 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/network/mcpe/handler/ItemStackResponseBuilder.php
View File

@ -70,14 +70,23 @@ final class ItemStackResponseBuilder{
foreach($slotIds as $slotId){
[$inventory, $slot] = $this->getInventoryAndSlot($containerInterfaceId, $slotId);
$itemStackInfo = $this->inventoryManager->getItemStackInfo($inventory, $slot);
if($itemStackInfo === null){
//TODO: what if a plugin closes the inventory while the transaction is ongoing?
throw new \LogicException("ItemStackInfo should never be null for an open inventory");
}
if($itemStackInfo->getRequestId() !== $this->requestId){
//the itemstack may have been synced due to transaction producing results that the client did not
//predict correctly, which will wipe out the tracked request ID (intentionally)
continue;
}
$item = $inventory->getItem($slot);
$info = $this->inventoryManager->trackItemStack($inventory, $slot, $item, $this->requestId);
$responseInfosByContainer[$containerInterfaceId][] = new ItemStackResponseSlotInfo(
$slotId,
$slotId,
$info->getItemStack()->getCount(),
$info->getStackId(),
$item->getCount(),
$itemStackInfo->getStackId(),
$item->hasCustomName() ? $item->getCustomName() : "",
0
);