From 5fd685e07d61ef670584ed11a52fd5f4b99a81a7 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 6 Jun 2022 19:29:44 +0100 Subject: [PATCH] TypeConverter: fix crash on arbitrary out-of-bounds item IDs I don't know why I didn't consider this fix necessary when the item meta bug was originally discovered. --- src/network/mcpe/convert/TypeConverter.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/network/mcpe/convert/TypeConverter.php b/src/network/mcpe/convert/TypeConverter.php index 856b398b6..2a74c9f07 100644 --- a/src/network/mcpe/convert/TypeConverter.php +++ b/src/network/mcpe/convert/TypeConverter.php @@ -234,6 +234,9 @@ class TypeConverter{ $compound = null; } } + if($id < -0x8000 || $id >= 0x7fff){ + throw new TypeConversionException("Item ID must be in range " . -0x8000 . " ... " . 0x7fff . " (received $id)"); + } if($meta < 0 || $meta >= 0x7fff){ //this meta value may have been restored from the NBT throw new TypeConversionException("Item meta must be in range 0 ... " . 0x7fff . " (received $meta)"); }