mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-12 00:39:45 +00:00
Code Issues Projects Releases Wiki Activity

World: rename get(HighestAdjacent)BlockSkyLight(At) to make it clear these are **potentials**, not the actual light level

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-10-31 16:47:34 +00:00
parent 241a50387b
commit 5f7b0994b9
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/world/World.php
View File

@ -1195,7 +1195,7 @@ class World implements ChunkManager{
* @return int 0-15 * @return int 0-15
*/ */
public function getRealBlockSkyLightAt(int $x, int $y, int $z) : int{ public function getRealBlockSkyLightAt(int $x, int $y, int $z) : int{
$light = $this->getBlockSkyLightAt($x, $y, $z) - $this->skyLightReduction; $light = $this->getPotentialBlockSkyLightAt($x, $y, $z) - $this->skyLightReduction;
return $light < 0 ? 0 : $light; return $light < 0 ? 0 : $light;
} }
@ -1219,7 +1219,7 @@ class World implements ChunkManager{
/** /**
* Returns the highest block light level available in the positions adjacent to the specified block coordinates. * Returns the highest block light level available in the positions adjacent to the specified block coordinates.
*/ */
public function getHighestAdjacentBlockSkyLight(int $x, int $y, int $z) : int{ public function getHighestAdjacentPotentialBlockSkyLight(int $x, int $y, int $z) : int{
$max = 0; $max = 0;
foreach([ foreach([
[$x + 1, $y, $z], [$x + 1, $y, $z],
@ -1236,7 +1236,7 @@ class World implements ChunkManager{
){ ){
continue; continue;
} }
$max = max($max, $this->getBlockSkyLightAt($x1, $y1, $z1)); $max = max($max, $this->getPotentialBlockSkyLightAt($x1, $y1, $z1));
} }
return $max; return $max;
} }
@ -1246,7 +1246,7 @@ class World implements ChunkManager{
* the world's current time of day and weather conditions. * the world's current time of day and weather conditions.
*/ */
public function getHighestAdjacentRealBlockSkyLight(int $x, int $y, int $z) : int{ public function getHighestAdjacentRealBlockSkyLight(int $x, int $y, int $z) : int{
return $this->getHighestAdjacentBlockSkyLight($x, $y, $z) - $this->skyLightReduction; return $this->getHighestAdjacentPotentialBlockSkyLight($x, $y, $z) - $this->skyLightReduction;
} }
/** /**
@ -1838,7 +1838,7 @@ class World implements ChunkManager{
* *
* @return int 0-15 * @return int 0-15
*/ */
public function getBlockSkyLightAt(int $x, int $y, int $z) : int{ public function getPotentialBlockSkyLightAt(int $x, int $y, int $z) : int{
return $this->getOrLoadChunk($x >> 4, $z >> 4, true)->getSubChunk($y >> 4)->getBlockSkyLightArray()->get($x & 0x0f, $y & 0xf, $z & 0x0f); return $this->getOrLoadChunk($x >> 4, $z >> 4, true)->getSubChunk($y >> 4)->getBlockSkyLightArray()->get($x & 0x0f, $y & 0xf, $z & 0x0f);
} }