mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 18:29:46 +00:00
Code Issues Projects Releases Wiki Activity

Do not load playerdata from disk just to op/deop/whitelist/dewhitelist

Browse Source 
this is an impressively dumb idea.
the playerdata is not used here in any capacity so it doesn't make sense to load it, especially considering that it takes a significant amount of time.
This commit is contained in:
Dylan K. Taylor 2020-11-27 18:06:59 +00:00
parent 5142281cfa
commit 5e44d5f75e
3 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/command/defaults/DeopCommand.php
View File

@ -57,12 +57,11 @@ class DeopCommand extends VanillaCommand{
throw new InvalidCommandSyntaxException(); throw new InvalidCommandSyntaxException();
} }
$player = $sender->getServer()->getOfflinePlayer($name); $sender->getServer()->removeOp($name);
$player->setOp(false); if(($player = $sender->getServer()->getPlayerExact($name)) !== null){
if($player instanceof Player){
$player->sendMessage(TextFormat::GRAY . "You are no longer op!"); $player->sendMessage(TextFormat::GRAY . "You are no longer op!");
} }
Command::broadcastCommandMessage($sender, new TranslationContainer("commands.deop.success", [$player->getName()])); Command::broadcastCommandMessage($sender, new TranslationContainer("commands.deop.success", [$name]));
return true; return true;
} }

7
src/command/defaults/OpCommand.php
View File

@ -57,12 +57,11 @@ class OpCommand extends VanillaCommand{
throw new InvalidCommandSyntaxException(); throw new InvalidCommandSyntaxException();
} }
$player = $sender->getServer()->getOfflinePlayer($name); $sender->getServer()->addOp($name);
Command::broadcastCommandMessage($sender, new TranslationContainer("commands.op.success", [$player->getName()])); if(($player = $sender->getServer()->getPlayerExact($name)) !== null){
if($player instanceof Player){
$player->sendMessage(TextFormat::GRAY . "You are now op!"); $player->sendMessage(TextFormat::GRAY . "You are now op!");
} }
$player->setOp(true); Command::broadcastCommandMessage($sender, new TranslationContainer("commands.op.success", [$name]));
return true; return true;
} }
} }

4
src/command/defaults/WhitelistCommand.php
View File

@ -99,12 +99,12 @@ class WhitelistCommand extends VanillaCommand{
} }
switch(strtolower($args[0])){ switch(strtolower($args[0])){
case "add": case "add":
$sender->getServer()->getOfflinePlayer($args[1])->setWhitelisted(true); $sender->getServer()->addWhitelist($args[1]);
Command::broadcastCommandMessage($sender, new TranslationContainer("commands.whitelist.add.success", [$args[1]])); Command::broadcastCommandMessage($sender, new TranslationContainer("commands.whitelist.add.success", [$args[1]]));
return true; return true;
case "remove": case "remove":
$sender->getServer()->getOfflinePlayer($args[1])->setWhitelisted(false); $sender->getServer()->removeWhitelist($args[1]);
Command::broadcastCommandMessage($sender, new TranslationContainer("commands.whitelist.remove.success", [$args[1]])); Command::broadcastCommandMessage($sender, new TranslationContainer("commands.whitelist.remove.success", [$args[1]]));
return true; return true;