From 5c8a625d88e511a6ebad765714b75f1a86dfd37f Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 30 Jan 2020 20:43:13 +0000 Subject: [PATCH] populate missing iterable value types in block namespace --- src/pocketmine/block/BaseRail.php | 17 +++++++++++++++++ src/pocketmine/block/Leaves.php | 3 +++ 2 files changed, 20 insertions(+) diff --git a/src/pocketmine/block/BaseRail.php b/src/pocketmine/block/BaseRail.php index e2b941f66..c06cced4c 100644 --- a/src/pocketmine/block/BaseRail.php +++ b/src/pocketmine/block/BaseRail.php @@ -99,6 +99,10 @@ abstract class BaseRail extends Flowable{ return false; } + /** + * @param int[] $connections + * @param int[][] $lookup + */ protected static function searchState(array $connections, array $lookup) : int{ $meta = array_search($connections, $lookup, true); if($meta === false){ @@ -114,6 +118,8 @@ abstract class BaseRail extends Flowable{ /** * Returns a meta value for the rail with the given connections. * + * @param int[] $connections + * * @throws \InvalidArgumentException if no state matches the given connections */ protected function getMetaForState(array $connections) : int{ @@ -160,6 +166,11 @@ abstract class BaseRail extends Flowable{ return $connections; } + /** + * @param int[] $constraints + * + * @return true[] + */ private function getPossibleConnectionDirections(array $constraints) : array{ switch(count($constraints)){ case 0: @@ -184,6 +195,9 @@ abstract class BaseRail extends Flowable{ } } + /** + * @return true[] + */ protected function getPossibleConnectionDirectionsOneConstraint(int $constraint) : array{ $opposite = Vector3::getOppositeSide($constraint & ~self::FLAG_ASCEND); @@ -243,6 +257,9 @@ abstract class BaseRail extends Flowable{ } } + /** + * @param int[] $connections + */ private function updateState(array $connections) : void{ if(count($connections) === 1){ $connections[] = Vector3::getOppositeSide($connections[0] & ~self::FLAG_ASCEND); diff --git a/src/pocketmine/block/Leaves.php b/src/pocketmine/block/Leaves.php index 2b0bf5511..95cc3aa4a 100644 --- a/src/pocketmine/block/Leaves.php +++ b/src/pocketmine/block/Leaves.php @@ -68,6 +68,9 @@ class Leaves extends Transparent{ return true; } + /** + * @param true[] $visited reference parameter + */ protected function findLog(Block $pos, array &$visited, int $distance, ?int $fromSide = null) : bool{ $index = $pos->x . "." . $pos->y . "." . $pos->z; if(isset($visited[$index])){