mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-10 05:34:54 +00:00
Code Issues Projects Releases Wiki Activity

Living: fix possible crash in getTargetBlock()

Browse Source 
ArrayOutOfBoundsException is not thrown by SPL anymore since the exception handler throwing it was removed by @shoghicp. Regardless, it seems cleaner to to check it properly.
This commit is contained in:
Dylan K. Taylor 2018-05-09 17:11:37 +01:00
parent 2ff2a2de08
commit 5c66c615bf
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/pocketmine/entity/Living.php
View File

@ -816,12 +816,9 @@ abstract class Living extends Entity implements Damageable{
* @return Block|null * @return Block|null
*/ */
public function getTargetBlock(int $maxDistance, array $transparent = []){ public function getTargetBlock(int $maxDistance, array $transparent = []){
try{ $line = $this->getLineOfSight($maxDistance, 1, $transparent);
$block = $this->getLineOfSight($maxDistance, 1, $transparent)[0]; if(!empty($line)){
if($block instanceof Block){ return array_shift($line);
return $block;
}
}catch(\ArrayOutOfBoundsException $e){
} }
return null; return null;