mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-18 12:04:46 +00:00
Code Issues Projects Releases Wiki Activity

ItemBlock: remember fuel time, fireproof and max stack size

Browse Source 
this avoids repeatedly creating blocks for no reason when calling these methods.

This does assume that these methods always return the same result for a given block type, but I think that's a fair enough assumption.
This commit is contained in:
Dylan K. Taylor
2022-08-27 18:04:11 +01:00
parent 4dabac8420
commit 5c5d96d00b
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/item/ItemBlock.php
View File

@@ -38,10 +38,18 @@ final class ItemBlock extends Item{
private int $blockTypeId; private int $blockTypeId;
private int $blockTypeData; private int $blockTypeData;
private int $fuelTime;
private bool $fireProof;
private int $maxStackSize;
public function __construct(Block $block){ public function __construct(Block $block){
parent::__construct(ItemIdentifier::fromBlock($block), $block->getName()); parent::__construct(ItemIdentifier::fromBlock($block), $block->getName());
$this->blockTypeId = $block->getTypeId(); $this->blockTypeId = $block->getTypeId();
$this->blockTypeData = $block->computeTypeData(); $this->blockTypeData = $block->computeTypeData();
$this->fuelTime = $block->getFuelTime();
$this->fireProof = $block->isFireProofAsItem();
$this->maxStackSize = $block->getMaxStackSize();
} }
protected function encodeType(RuntimeDataWriter $w) : void{ protected function encodeType(RuntimeDataWriter $w) : void{
@@ -60,14 +68,14 @@ final class ItemBlock extends Item{
} }
public function getFuelTime() : int{ public function getFuelTime() : int{
return $this->getBlock()->getFuelTime(); return $this->fuelTime;
} }
public function isFireProof() : bool{ public function isFireProof() : bool{
return $this->getBlock()->isFireProofAsItem(); return $this->fireProof;
} }
public function getMaxStackSize() : int{ public function getMaxStackSize() : int{
return $this->getBlock()->getMaxStackSize(); return $this->maxStackSize;
} }
} }