mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 18:32:55 +00:00
Code Issues Projects Releases Wiki Activity

Chunk: stop exposing SplFixedArray<SubChunk> to the API

Browse Source 
this fixes a large number of PHPStan errors, and also brings us a step closer to negative-build-height readiness.
This commit is contained in:
Dylan K. Taylor
2021-10-01 22:17:28 +01:00
parent 42bf9578ce
commit 5b818827db
5 changed files with 14 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/world/format/Chunk.php
View File

@ -299,11 +299,11 @@ class Chunk{
}
/**
* @return \SplFixedArray|SubChunk[]
* @phpstan-return \SplFixedArray<SubChunk>
* @return SubChunk[]
* @phpstan-return array<int, SubChunk>
*/
public function getSubChunks() : \SplFixedArray{
return $this->subChunks;
public function getSubChunks() : array{
return $this->subChunks->toArray();
}
/**

2
src/world/format/io/FastChunkSerializer.php
View File

@ -67,7 +67,7 @@ final class FastChunkSerializer{
//subchunks
$subChunks = $chunk->getSubChunks();
$count = $subChunks->count();
$count = count($subChunks);
$stream->putByte($count);
foreach($subChunks as $y => $subChunk){