mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-04 00:55:14 +00:00
Code Issues Projects Releases Wiki Activity

Item: Improve performance of nbtSerialize() (#4831)

Browse Source 
Replace hasNamedTag() with $nbt->count() > 0
This avoids a duplicate indirect call to Item::serializeCompoundTag() method call when serializing items with namedtags.
This commit is contained in:
Muqsit Rayyan
2022-02-16 05:32:12 +05:00
committed by GitHub
parent 55c744cc00
commit 55dfacea8d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/item/Item.php
View File

@ -659,8 +659,9 @@ class Item implements \JsonSerializable{
->setByte("Count", Binary::signByte($this->count)) ->setByte("Count", Binary::signByte($this->count))
->setShort("Damage", $this->getMeta()); ->setShort("Damage", $this->getMeta());
if($this->hasNamedTag()){ $tag = $this->getNamedTag();
$result->setTag("tag", $this->getNamedTag()); if($tag->count() > 0){
$result->setTag("tag", $tag);
} }
if($slot !== -1){ if($slot !== -1){