From 54cb5ee0fa99de749d7d18514988c3ac08151a47 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Wed, 7 Apr 2021 13:09:52 +0100 Subject: [PATCH] ItemTranslator: ensure that the correct meta value is returned after translation -1 is a PM-specific thing. Right now there is a hack in the NetworkBinaryStream which prevents this from becoming a problem, but that might not be the case in future. --- src/pocketmine/network/mcpe/convert/ItemTranslator.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pocketmine/network/mcpe/convert/ItemTranslator.php b/src/pocketmine/network/mcpe/convert/ItemTranslator.php index 30110ed13..530f4af4c 100644 --- a/src/pocketmine/network/mcpe/convert/ItemTranslator.php +++ b/src/pocketmine/network/mcpe/convert/ItemTranslator.php @@ -139,6 +139,9 @@ final class ItemTranslator{ * @phpstan-return array{int, int} */ public function toNetworkId(int $internalId, int $internalMeta) : array{ + if($internalMeta === -1){ + $internalMeta = 0x7fff; + } if(isset($this->complexCoreToNetMapping[$internalId][$internalMeta])){ return [$this->complexCoreToNetMapping[$internalId][$internalMeta], 0]; }