mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-08-30 06:55:11 +00:00
Code Issues Projects Releases Wiki Activity

Normal: Fixed bug that never lets mountainous terrain generate (#4170)

Browse Source
This commit is contained in:
TheShermanTanker 2021-04-14 00:56:57 +08:00 committed by GitHub
parent f74ff1fcd4
commit 547503e8f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/pocketmine/level/generator/normal/Normal.php
View File

@ -144,12 +144,9 @@ class Normal extends Generator{
return Biome::BIRCH_FOREST; return Biome::BIRCH_FOREST;
} }
}else{ }else{
//FIXME: This will always cause River to be used since the rainfall is always greater than 0.8 if we if($temperature < 0.20){
//reached this branch. However I don't think that substituting temperature for rainfall is correct given
//that mountain biomes are supposed to be pretty cold.
if($rainfall < 0.25){
return Biome::MOUNTAINS; return Biome::MOUNTAINS;
}elseif($rainfall < 0.70){ }elseif($temperature < 0.40){
return Biome::SMALL_MOUNTAINS; return Biome::SMALL_MOUNTAINS;
}else{ }else{
return Biome::RIVER; return Biome::RIVER;