mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-07 10:31:51 +00:00
Code Issues Projects Releases Wiki Activity

BaseInventory: stop mutating item for no reason in canAddItem()

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-02-25 20:30:37 +00:00
parent 04581e2700
commit 53067c26d7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pocketmine/inventory/BaseInventory.php
View File

@ -246,18 +246,18 @@ abstract class BaseInventory implements Inventory{
} }
public function canAddItem(Item $item) : bool{ public function canAddItem(Item $item) : bool{
$item = clone $item; $count = $item->getCount();
for($i = 0, $size = $this->getSize(); $i < $size; ++$i){ for($i = 0, $size = $this->getSize(); $i < $size; ++$i){
$slot = $this->getItem($i); $slot = $this->getItem($i);
if($item->equals($slot)){ if($item->equals($slot)){
if(($diff = $slot->getMaxStackSize() - $slot->getCount()) > 0){ if(($diff = $slot->getMaxStackSize() - $slot->getCount()) > 0){
$item->setCount($item->getCount() - $diff); $count -= $diff;
} }
}elseif($slot->isNull()){ }elseif($slot->isNull()){
$item->setCount($item->getCount() - $this->getMaxStackSize()); $count -= $this->getMaxStackSize();
} }
if($item->getCount() <= 0){ if($count <= 0){
return true; return true;
} }
} }