mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

BaseInventory: Don't keep calling getSize() over and over and over again

Browse Source
This commit is contained in:
Dylan K. Taylor
2017-09-27 11:24:16 +01:00
parent 4b63a22f8c
commit 52bd042bde
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/inventory/BaseInventory.php
View File

@ -219,7 +219,7 @@ abstract class BaseInventory implements Inventory{
$item = clone $item; $item = clone $item;
$checkDamage = !$item->hasAnyDamageValue(); $checkDamage = !$item->hasAnyDamageValue();
$checkTags = $item->hasCompoundTag(); $checkTags = $item->hasCompoundTag();
for($i = 0; $i < $this->getSize(); ++$i){ for($i = 0, $size = $this->getSize(); $i < $size; ++$i){
$slot = $this->getItem($i); $slot = $this->getItem($i);
if($item->equals($slot, $checkDamage, $checkTags)){ if($item->equals($slot, $checkDamage, $checkTags)){
if(($diff = $slot->getMaxStackSize() - $slot->getCount()) > 0){ if(($diff = $slot->getMaxStackSize() - $slot->getCount()) > 0){
@ -249,7 +249,7 @@ abstract class BaseInventory implements Inventory{
$emptySlots = []; $emptySlots = [];
for($i = 0; $i < $this->getSize(); ++$i){ for($i = 0, $size = $this->getSize(); $i < $size; ++$i){
$item = $this->getItem($i); $item = $this->getItem($i);
if($item->isNull()){ if($item->isNull()){
$emptySlots[] = $i; $emptySlots[] = $i;
@ -304,7 +304,7 @@ abstract class BaseInventory implements Inventory{
} }
} }
for($i = 0; $i < $this->getSize(); ++$i){ for($i = 0, $size = $this->getSize(); $i < $size; ++$i){
$item = $this->getItem($i); $item = $this->getItem($i);
if($item->isNull()){ if($item->isNull()){
continue; continue;