mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-10 05:34:54 +00:00
Code Issues Projects Releases Wiki Activity

World->getHighestBlockAt() now throws an exception instead of returning -1 in ungenerated terrain

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-11-26 19:44:22 +00:00
parent fd99445c5b
commit 4ea5401d72
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/world/World.php
View File

@ -2056,13 +2056,14 @@ class World implements ChunkManager{
/** /**
* Gets the highest block Y value at a specific $x and $z * Gets the highest block Y value at a specific $x and $z
* *
* @return int 0-255, or -1 if the chunk is not generated * @return int 0-255
* @throws WorldException if the terrain is not generated
*/ */
public function getHighestBlockAt(int $x, int $z) : int{ public function getHighestBlockAt(int $x, int $z) : int{
if(($chunk = $this->loadChunk($x >> 4, $z >> 4, false)) !== null){ if(($chunk = $this->loadChunk($x >> 4, $z >> 4, false)) !== null){
return $chunk->getHighestBlockAt($x & 0x0f, $z & 0x0f); return $chunk->getHighestBlockAt($x & 0x0f, $z & 0x0f);
} }
return -1; //TODO: this should probably throw an exception (terrain not generated yet) throw new WorldException("Cannot get highest block in an ungenerated chunk");
} }
/** /**