mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-11 12:27:51 +00:00
Code Issues Projects Releases Wiki Activity

PluginManager: fixed plugins being able to alter groups of other plugins' permissions

Browse Source 
this could happen if a plugin declared a permission already declared by another plugin, and then declared a different default for it (e.g. true instead of op).
This commit is contained in:
Dylan K. Taylor 2021-11-06 16:32:19 +00:00
parent f81c55ce6c
commit 4cb6c7dc1e
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugin/PluginManager.php
View File

@ -172,7 +172,9 @@ class PluginManager{
$everyoneRoot = $permManager->getPermission(DefaultPermissions::ROOT_USER); $everyoneRoot = $permManager->getPermission(DefaultPermissions::ROOT_USER);
foreach($description->getPermissions() as $default => $perms){ foreach($description->getPermissions() as $default => $perms){
foreach($perms as $perm){ foreach($perms as $perm){
$permManager->addPermission($perm); if(!$permManager->addPermission($perm)){
continue; //TODO: this should be reported as an error and prevent the plugin from loading
}
switch($default){ switch($default){
case PermissionParser::DEFAULT_TRUE: case PermissionParser::DEFAULT_TRUE:
$everyoneRoot->addChild($perm->getName(), true); $everyoneRoot->addChild($perm->getName(), true);