mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Implemented event handler inheritance, allow registering handlers for any valid event (#1792)

Browse Source 
* Event handlers always handle subclass events. public static $handlerList no longer required.
* Removed $handlerList declarations
* HandlerList cleanup: Removed HandlerList->handlers and related bake methods
* Removed obsolete Event->getHandlers()
* EventPriority: Added fromString()
* PluginManager: throw exceptions on registering handlers with invalid priorities

This allows specifying a handler of `EntityDamageEvent` which will handle any instanceof it (as per current behaviour), AND also now allows specifying a handler specifically for `EntityDamageByEntityEvent`, which only handles `EntityDamageEvent`.

This was not previously possible due to limitations in the way handlers were registered.

Abstract events may not be handled unless they declare the `@allowHandle` PhpDoc tag.
This commit is contained in:
SOFe
2018-03-21 01:05:09 +08:00
committed by Dylan K. Taylor
parent 1648fff916
commit 49fbbea7bf
106 changed files with 204 additions and 363 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/pocketmine/event/Event.php
View File

@ -28,14 +28,6 @@ namespace pocketmine\event;
abstract class Event{
/**
* Any callable event must declare the static variable
*
* public static $handlerList = null;
*
* Not doing so will deny the proper event initialization
*/
/** @var string|null */
protected $eventName = null;
/** @var bool */
@ -75,16 +67,4 @@ abstract class Event{
/** @var Event $this */
$this->isCancelled = $value;
}
/**
* @return HandlerList
*/
public function getHandlers() : HandlerList{
if(static::$handlerList === null){
static::$handlerList = new HandlerList();
}
return static::$handlerList;
}
}