mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 17:59:48 +00:00
Code Issues Projects Releases Wiki Activity

cleanup block dual bounding box clusterfuck

Browse Source 
"bounding box" serves no tangible purpose, only collision boxes do right now.
This commit is contained in:
Dylan K. Taylor
2019-08-15 17:23:55 +01:00
parent d58339b2fd
commit 4898a35613
40 changed files with 202 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/block/Wall.php
View File

@ -53,7 +53,7 @@ class Wall extends Transparent{
$this->up = $this->getSide(Facing::UP)->getId() !== BlockLegacyIds::AIR;
}
protected function recalculateBoundingBox() : ?AxisAlignedBB{
protected function recalculateCollisionBoxes() : array{
//walls don't have any special collision boxes like fences do
$north = isset($this->connections[Facing::NORTH]);
@ -73,11 +73,13 @@ class Wall extends Transparent{
$inset = 0.3125;
}
return AxisAlignedBB::one()
->extend(Facing::UP, 0.5)
->trim(Facing::NORTH, $north ? 0 : $inset)
->trim(Facing::SOUTH, $south ? 0 : $inset)
->trim(Facing::WEST, $west ? 0 : $inset)
->trim(Facing::EAST, $east ? 0 : $inset);
return [
AxisAlignedBB::one()
->extend(Facing::UP, 0.5)
->trim(Facing::NORTH, $north ? 0 : $inset)
->trim(Facing::SOUTH, $south ? 0 : $inset)
->trim(Facing::WEST, $west ? 0 : $inset)
->trim(Facing::EAST, $east ? 0 : $inset)
];
}
}