mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Revert "resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download"

Browse Source 
This reverts commit 06ec8b8397.

unfortunately, this had some unanticipated side effects, thanks to
idiotic behaviour in the client ... when having optional downloads but
trying to force resources, the client chokes because it thinks the
server is forcing it to apply a pack that it doesn't have. Since
there's no way to detect when this problem occurs in the protocol, the
only option is to revert this.
This commit is contained in:
Dylan K. Taylor
2020-01-04 16:04:07 +00:00
parent 6490a49c70
commit 4794ba236a
4 changed files with 4 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/network/mcpe/protocol/ResourcePackStackPacket.php
View File

@ -35,7 +35,7 @@ class ResourcePackStackPacket extends DataPacket{
public const NETWORK_ID = ProtocolInfo::RESOURCE_PACK_STACK_PACKET;
/** @var bool */
public $removeClientResourcePacks = false;
public $mustAccept = false;
/** @var ResourcePack[] */
public $behaviorPackStack = [];
@ -48,7 +48,7 @@ class ResourcePackStackPacket extends DataPacket{
public $baseGameVersion = ProtocolInfo::MINECRAFT_VERSION_NETWORK;
protected function decodePayload(){
$this->removeClientResourcePacks = $this->getBool();
$this->mustAccept = $this->getBool();
$behaviorPackCount = $this->getUnsignedVarInt();
while($behaviorPackCount-- > 0){
$this->getString();
@ -68,7 +68,7 @@ class ResourcePackStackPacket extends DataPacket{
}
protected function encodePayload(){
$this->putBool($this->removeClientResourcePacks);
$this->putBool($this->mustAccept);
$this->putUnsignedVarInt(count($this->behaviorPackStack));
foreach($this->behaviorPackStack as $entry){