Added Effects base, /effect and methods

src/pocketmine/command/SimpleCommandMap.php

@@ -27,6 +27,7 @@ use pocketmine\command\defaults\BanListCommand;
 use pocketmine\command\defaults\DefaultGamemodeCommand;
 use pocketmine\command\defaults\DeopCommand;
 use pocketmine\command\defaults\DifficultyCommand;
+use pocketmine\command\defaults\EffectCommand;
 use pocketmine\command\defaults\GamemodeCommand;
 use pocketmine\command\defaults\GiveCommand;
 use pocketmine\command\defaults\HelpCommand;
@@ -98,6 +99,7 @@ class SimpleCommandMap implements CommandMap{
 		$this->register("pocketmine", new SaveOffCommand("save-off"));
 		$this->register("pocketmine", new SaveCommand("save-all"));
 		$this->register("pocketmine", new GiveCommand("give"));
+		$this->register("pocketmine", new EffectCommand("effect"));
 		$this->register("pocketmine", new GamemodeCommand("gamemode"));
 		$this->register("pocketmine", new KillCommand("kill"));
 		$this->register("pocketmine", new SpawnpointCommand("spawnpoint"));

src/pocketmine/command/defaults/EffectCommand.php

@@ -0,0 +1,113 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+namespace pocketmine\command\defaults;
+
+use pocketmine\command\Command;
+use pocketmine\command\CommandSender;
+use pocketmine\entity\Effect;
+use pocketmine\entity\InstantEffect;
+use pocketmine\utils\TextFormat;
+
+class EffectCommand extends VanillaCommand{
+
+	public function __construct($name){
+		parent::__construct(
+			$name,
+			"Adds/Removes effects on players",
+			"/effect <player> <effect|clear> [seconds] [amplifier]"
+		);
+		$this->setPermission("pocketmine.command.effect");
+	}
+
+	public function execute(CommandSender $sender, $currentAlias, array $args){
+		if(!$this->testPermission($sender)){
+			return true;
+		}
+
+		if(count($args) < 2){
+			$sender->sendMessage(TextFormat::RED . "Usage: " . $this->usageMessage);
+
+			return true;
+		}
+
+		$player = $sender->getServer()->getPlayer($args[0]);
+
+		if($player === null){
+			$sender->sendMessage(TextFormat::RED . "Player {$args[0]} not found");
+			return true;
+		}
+
+		if(strtolower($args[1]) === "clear"){
+			foreach($player->getEffects() as $effect){
+				$player->removeEffect($effect->getId());
+			}
+
+			$sender->sendMessage("Took all effects from " . $player->getDisplayName());
+			return true;
+		}
+
+		$effect = Effect::getEffectByName($args[1]);
+
+		if($effect === null){
+			$effect = Effect::getEffect((int) $args[1]);
+		}
+
+		if($effect === null){
+			$sender->sendMessage(TextFormat::RED . "Effect {$args[1]} not found");
+			return true;
+		}
+
+		$duration = 300;
+		$amplification = 0;
+
+		if(count($args) >= 3){
+			$duration = (int) $args[2];
+			if(!($effect instanceof InstantEffect)){
+				$duration *= 20;
+			}
+		}elseif($effect instanceof InstantEffect){
+			$duration = 1;
+		}
+
+		if(count($args) >= 4){
+			$amplification = (int) $args[3];
+		}
+
+		if($duration === 0){
+			if(!$player->hasEffect($effect->getId())){
+				$sender->sendMessage("Couldn't take ". $effect->getName() ." from ". $player->getDisplayName());
+				return true;
+			}
+
+			$player->removeEffect($effect->getId());
+			$sender->sendMessage("Took ". $effect->getName() ." from ". $player->getDisplayName());
+		}else{
+			$effect->setDuration($duration)->setAmplifier($amplification);
+
+			$player->addEffect($effect);
+			self::broadcastCommandMessage($sender, "Given ". $effect->getName() ." (ID ". $effect->getId()." ) * ". $effect->getAmplifier()." to ". $player->getDisplayName() ." for ". ($effect->getDuration() / 20) ." seconds");
+		}
+
+
+		return true;
+	}
+}

src/pocketmine/command/defaults/GiveCommand.php

@@ -46,7 +46,7 @@ class GiveCommand extends VanillaCommand{
 		if(count($args) < 2){
 			$sender->sendMessage(TextFormat::RED . "Usage: " . $this->usageMessage);
 
-			return false;
+			return true;
 		}
 
 		$player = $sender->getServer()->getPlayer($args[0]);